dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibThreading: Use WeakEventLoopReference in BackgroundAction

Browse source 
BackgroundAction already assumes the event loop is alive, now we can
assert that it is.
This commit is contained in:
Zaggy1024 2025-12-08 13:44:17 -06:00 committed by Gregory Bertilson
parent 3742138cc3
commit 786ea6c8f2
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibThreading/BackgroundAction.h
View file

@ -76,7 +76,7 @@ private:
if (on_error.has_value())
m_on_error = on_error.release_value();
enqueue_work([self = NonnullRefPtr(*this), promise = move(promise), origin_event_loop = &Core::EventLoop::current()]() mutable {
enqueue_work([self = NonnullRefPtr(*this), promise = move(promise), origin_event_loop = Core::EventLoop::current_weak()]() mutable {
auto result = self->m_action(*self);
// The event loop cancels the promise when it exits.
@ -88,7 +88,7 @@ private:
// If there is no completion callback, we don't rely on the user keeping around the event loop.
if (self->m_on_complete) {
origin_event_loop->deferred_invoke([self, promise = move(promise)] {
origin_event_loop->take()->deferred_invoke([self, promise = move(promise)] {
// Our promise's resolution function will never error.
(void)promise->resolve(*self);
});
@ -102,7 +102,7 @@ private:
promise->reject(Error::from_errno(ECANCELED));
if (!self->m_canceled && self->m_on_error) {
origin_event_loop->deferred_invoke([self, error = move(error)]() mutable {
origin_event_loop->take()->deferred_invoke([self, error = move(error)]() mutable {
self->m_on_error(move(error));
});
} else if (self->m_on_error) {