dmaax/ladybird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

LibWeb: Do not pass GC::Ptr by reference

Browse source 
Also change it to `GC::Ref` since it's nonnull.
This commit is contained in:
devgianlu 2026-02-22 18:02:36 +01:00 committed by Tim Flynn
parent fd80acd730
commit f14410c19f
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/CredentialManagement/PasswordCredential.cpp
View file

@ -12,7 +12,7 @@ namespace Web::CredentialManagement {
GC_DEFINE_ALLOCATOR(PasswordCredential);
// https://www.w3.org/TR/credential-management-1/#dom-passwordcredential-passwordcredential
WebIDL::ExceptionOr<GC::Ref<PasswordCredential>> PasswordCredential::construct_impl(JS::Realm& realm, GC::Ptr<HTML::HTMLFormElement> const& form)
WebIDL::ExceptionOr<GC::Ref<PasswordCredential>> PasswordCredential::construct_impl(JS::Realm& realm, GC::Ref<HTML::HTMLFormElement> form)
{
// 1. Let origin be the current settings object's origin.
auto origin = HTML::current_principal_settings_object().origin();

2
Libraries/LibWeb/CredentialManagement/PasswordCredential.h
View file

@ -23,7 +23,7 @@ class PasswordCredential final
GC_DECLARE_ALLOCATOR(PasswordCredential);
public:
[[nodiscard]] static WebIDL::ExceptionOr<GC::Ref<PasswordCredential>> construct_impl(JS::Realm&, GC::Ptr<HTML::HTMLFormElement> const&);
[[nodiscard]] static WebIDL::ExceptionOr<GC::Ref<PasswordCredential>> construct_impl(JS::Realm&, GC::Ref<HTML::HTMLFormElement>);
[[nodiscard]] static WebIDL::ExceptionOr<GC::Ref<PasswordCredential>> construct_impl(JS::Realm&, PasswordCredentialData const&);
virtual ~PasswordCredential() override;

2
Libraries/LibWeb/CredentialManagement/PasswordCredentialOperations.cpp
View file

@ -11,7 +11,7 @@
namespace Web::CredentialManagement {
// https://www.w3.org/TR/credential-management-1/#abstract-opdef-create-a-passwordcredential-from-an-htmlformelement
WebIDL::ExceptionOr<GC::Ref<PasswordCredential>> create_password_credential(JS::Realm& realm, GC::Ptr<HTML::HTMLFormElement> const& form, URL::Origin origin)
WebIDL::ExceptionOr<GC::Ref<PasswordCredential>> create_password_credential(JS::Realm& realm, GC::Ref<HTML::HTMLFormElement> form, URL::Origin origin)
{
// 1. Let data be a new PasswordCredentialData dictionary.
PasswordCredentialData data;

2
Libraries/LibWeb/CredentialManagement/PasswordCredentialOperations.h
View file

@ -10,7 +10,7 @@
namespace Web::CredentialManagement {
WebIDL::ExceptionOr<GC::Ref<PasswordCredential>> create_password_credential(JS::Realm& realm, GC::Ptr<HTML::HTMLFormElement> const&, URL::Origin);
WebIDL::ExceptionOr<GC::Ref<PasswordCredential>> create_password_credential(JS::Realm& realm, GC::Ref<HTML::HTMLFormElement>, URL::Origin);
WebIDL::ExceptionOr<GC::Ref<PasswordCredential>> create_password_credential(JS::Realm& realm, PasswordCredentialData const&, URL::Origin);
}